[BridgeImplementationTest] Rewritten unit test to check bridges #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see, Travis already performs this test, which exhibits the problem described above. |
logmanoriginal
requested changes
Dec 28, 2018
fulmeek
commented
Dec 28, 2018
logmanoriginal
approved these changes
Jan 5, 2019
logmanoriginal
pushed a commit
that referenced
this pull request
Jan 5, 2019
* [DealabsBridge] fixed parameters * [DemonoidBridge] added parameter context names * [DevToBridge] fixed parameters * [ExtremeDownloadBridge] fixed parameters * [GithubIssueBridge] fixed parameters * [InstagramBridge] added parameter context names * [MydealsBridge] fixed parameters * [OnVaSortirBridge] fixed parameters * [ThingyverseBridge] fixed parameters * [HotUKDealsBridge] fixed parameters * [FeedExpanderExample] added proper URI * [GQMagazineBridge] fixed parameters and getDomain() * [MozillaSecurityBridge] fixed filename References #980
|
Thanks for the feedback. You are right, 0 would have set incorrect flags. I've merged #984. Please rebase this branch to get a successful build. |
… they are actually empty
There are simply too many bridges that won't work with SSL.
Co-Authored-By: fulmeek <36341513+fulmeek@users.noreply.github.com>
Do you see the difference? Travis did.
fulmeek
force-pushed
the
BridgeImplementationTest
branch
from
379421b to
4230198
Compare
|
This should do it :) |
|
Merged. Thanks again for the PR! |
infominer33
pushed a commit
to web-work-tools/rss-bridge
that referenced
this pull request
Apr 17, 2020
* [DealabsBridge] fixed parameters * [DemonoidBridge] added parameter context names * [DevToBridge] fixed parameters * [ExtremeDownloadBridge] fixed parameters * [GithubIssueBridge] fixed parameters * [InstagramBridge] added parameter context names * [MydealsBridge] fixed parameters * [OnVaSortirBridge] fixed parameters * [ThingyverseBridge] fixed parameters * [HotUKDealsBridge] fixed parameters * [FeedExpanderExample] added proper URI * [GQMagazineBridge] fixed parameters and getDomain() * [MozillaSecurityBridge] fixed filename References RSS-Bridge#980
infominer33
pushed a commit
to web-work-tools/rss-bridge
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a completely rewritten unit test to check whether the bridges are implemented as mentioned in the wiki.
It performs the following tests on each bridge:
However, it does not perform any item checks. Since the generated items heavily depend on the source and the actual parameters, they should be checked directly by the format classes or an intermediate item class to generate a valid feed.
Unfortunately, there are many bridges that do not pass this unit test. They mostly have less clean parameter lists, or they don't use HTTPS even though they usually could. It may take some effort to fix them all. I'm not sure if we should force HTTPS though.
I'm usually not comfortable with completely replacing something that has evolved over the time. What do you think?