refactor!: code optimization as stricter linters are in place #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenryQW
commented
May 1, 2024
internal/service/scheduler/snapshot/operation_pool/operation_pool.go
Outdated
Show resolved
Hide resolved
HenryQW
commented
May 1, 2024
| } | ||
|
|
||
| // should not include genesis account | ||
| if nodeInfo.Account == ethereum.AddressGenesis { |
There was a problem hiding this comment.
I am not sure why we should check AddressGenesis here?
HenryQW
commented
May 1, 2024
HenryQW
commented
May 1, 2024
| @@ -24,7 +25,7 @@ import ( | |||
| "go.uber.org/zap" | |||
| ) | |||
|
|
|||
| var ( | |||
| var ( // FIXME: Name should be "operation_pool", update the file naem too. | |||
There was a problem hiding this comment.
I am keeping the file name unchanged so we can have a diff view. It eventually needs to be changed.
There was a problem hiding this comment.
Same for the db table name, search for // FIXME
HenryQW
changed the title
HenryQW
commented
May 1, 2024
| if nodeInfo.Account == ethereum.AddressGenesis { | ||
| return nil | ||
| } | ||
|
|
||
| mutex.Lock() | ||
| defer mutex.Unlock() |
There was a problem hiding this comment.
I do not think mutex is required here, we can just use the range index to avoid race conditions.
HenryQW
commented
May 1, 2024
| } | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func (s *server) getNodesFromDB(ctx context.Context) ([]*schema.Node, error) { | ||
| nodes, err := s.databaseClient.FindNodes(ctx, schema.FindNodesQuery{}) |
There was a problem hiding this comment.
when the number of nodes increases, lacking paginations will cause problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make dev miserable again