Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.2.0-beta.0 Sidebar bug #1512

Closed
2 of 4 tasks
EnterMan123 opened this issue Nov 8, 2024 · 26 comments
Closed
2 of 4 tasks

v0.2.0-beta.0 Sidebar bug #1512

EnterMan123 opened this issue Nov 8, 2024 · 26 comments
Assignees

Comments

@EnterMan123
Copy link

Describe the bug

  1. I selected a single feed and tried to drag it, but I couldn't. It entered multi-select mode, and the triggers for multi-select and dragging are unclear.
1.mp4
  1. These two sorting methods cause issues when using multi-select.
    Image
00-16-49.mp4
  1. Once you've multi-selected, you can't click on a selected item to deselect it.
00-19-34.mp4
  1. I am unable to view the content at the bottom, unless I enlarge the window.
01-05-27.mp4

Feed Info

X

Reproduction Video

No response

Environment

Environment

App Version: 0.2.0-beta.0
OS: Windows
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Follow/0.2.0-beta.0 Chrome/130.0.6723.59 Electron/33.0.2 Safari/537.36
Env: electron
Browser: Chrome
Session Trace Id: 7tZLayeRkRaLl7Nrv3Ts4

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.

Contributions

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)
Copy link

linear bot commented Nov 8, 2024

@Innei
Copy link
Member

Innei commented Nov 9, 2024

@hyoban take a look this

@hyoban hyoban mentioned this issue Nov 9, 2024
5 tasks
@hyoban
Copy link
Member

hyoban commented Nov 11, 2024

Can you reproduce 2 now?

hyoban added a commit that referenced this issue Nov 11, 2024
hyoban added a commit that referenced this issue Nov 11, 2024
@EnterMan123
Copy link
Author

EnterMan123 commented Nov 11, 2024

11-36-08.mp4

Violent Flickering

@EnterMan123
Copy link
Author

EnterMan123 commented Nov 11, 2024

  1. It can be dragged into an off-screen (or invisible) space.
11-47-58.mp4
  1. The current deselection mechanism is unusual, and I don't think it's necessary. It causes previously selected items to be deselected, keeping only the newly selected items highlighted.
12-00-11.mp4

@hyoban
Copy link
Member

hyoban commented Nov 11, 2024

I cannot reproduce 2, please provide a complete screen recording of the reproduction process. 6 has been fixed in the latest dev.

@EnterMan123
Copy link
Author

12-01-45.mp4

Image

Please be mindful of the selection sorting method.

@hyoban
Copy link
Member

hyoban commented Nov 11, 2024

I got it, you changed the sorting method during the feed selection process, which will cause problems.

The selected feed should be reset after changing the sorting method.

@hyoban
Copy link
Member

hyoban commented Nov 11, 2024

I may have made a mistake. Is the flashing feed related to the fact that they are set to private?

@EnterMan123
Copy link
Author

EnterMan123 commented Nov 11, 2024

12-17-43.mp4

I don't think that's the case. I've turned off all the private feed settings. Even if I click randomly, the order changes, so it seems to be an issue with the sorting method.

@hyoban
Copy link
Member

hyoban commented Nov 11, 2024

So this doesn't seem to be related to dnd, can you open a new issue and link to the discussion here?

hyoban added a commit that referenced this issue Nov 11, 2024
@hyoban
Copy link
Member

hyoban commented Nov 11, 2024

5 fixed in 8666b41

@EnterMan123
Copy link
Author

EnterMan123 commented Nov 11, 2024

12-34-35.mp4

Confirm that this issue occurs with all sorting methods.

Image

Regarding point 2, the sorting method within the red box triggers the issue 100% of the time, while the green one is harder to trigger, but it still occurs.

@hyoban
Copy link
Member

hyoban commented Nov 11, 2024

Please provide all feed URLs under sspai.com

@EnterMan123
Copy link
Author

EnterMan123 commented Nov 11, 2024

I added it randomly through the follow search feature.

This issue also occurs with different feeds in various views.

@hyoban
Copy link
Member

hyoban commented Nov 11, 2024

I have reproduced problem 2 on the web page of the current prod environment, but it has not been reproduced on the latest dev branch. Can you help me try the latest version? Because there have been a lot of changes about dnd today.

https://github.com/RSSNext/Follow/actions/runs/11774868921

@EnterMan123
Copy link
Author

EnterMan123 commented Nov 11, 2024

22-14-08.mp4
22-16-51.mp4

It's getting worse

@hyoban
Copy link
Member

hyoban commented Nov 11, 2024

Are you holding the command key while dragging?

@EnterMan123
Copy link
Author

left mouse button only

@EnterMan123
Copy link
Author

22-23-36.mp4

@EnterMan123
Copy link
Author

22-28-46.mp4

@hyoban
Copy link
Member

hyoban commented Nov 11, 2024

Can you contact me at https://t.me/hyoban? I may need more information to debug this issue

@EnterMan123
Copy link
Author

EnterMan123 commented Nov 16, 2024

1234.mp4

🔸Latest Test: Disabling auto-grouping in version 0.2.1-nightly.20241115 seems to improve the situation.


1345.mp4

🔸Alright, You can notice that after disabling auto-grouping, the feeds without groups are in good condition, while my created Group 1 is still consistently disorganized.


41515.mp4

🔸I completely deleted all the groups, and it seems much better now.


123214.mp4

🔸When I created the groups again...


I believe we are getting close to the truth.

It’s clear that after deleting all the groups (including custom ones), the situation improved significantly. First, it’s most likely an issue with the grouping. Second, the sorting method might also be a factor.

This is my assumption. @hyoban

@hyoban
Copy link
Member

hyoban commented Nov 18, 2024

Can you help me try this version? https://github.com/RSSNext/Follow/actions/runs/11886777612

@EnterMan123
Copy link
Author

EnterMan123 commented Nov 18, 2024

I tested version 0.2.2-beta.0 and believe this issue has been resolved. However, there is still a 1% chance of sorting errors, while it works correctly 99% of the time.

@hyoban
Copy link
Member

hyoban commented Nov 18, 2024

Glad to hear this, if you have more questions feel free to create a new issue

@hyoban hyoban closed this as completed Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants