Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: register or login with email and password #2075

Merged
merged 42 commits into from
Dec 16, 2024
Merged

Conversation

hyoban
Copy link
Member

@hyoban hyoban commented Dec 9, 2024

Description

PR Type

  • Feature
  • Bugfix
  • Hotfix
  • Other (please describe):

Linked Issues

Additional context

Changelog

  • I have updated the changelog/next.md with my changes.

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
follow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 11:00am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
follow-external-ssr ⬜️ Ignored (Inspect) Visit Preview Dec 16, 2024 11:00am

@follow-reviewer-bot
Copy link

Suggested PR Title:

feat(auth): add password update feature and email login

Change Summary:
This PR introduces a new password update feature by adding a new UpdatePasswordForm that allows users to set or change their passwords. It modifies the authentication process to handle email and password login, allowing existing or new users to authenticate using credentials. Additionally, error handling for user feedback has been refined. Various localization changes have also been made to accommodate the new features. This enhances user account security and provides a better user experience.

Code Review:
No change requests necessary.

Copy link

github-actions bot commented Dec 9, 2024

Linting and formatting issues were automatically fixed. Please review the changes.

@hyoban hyoban changed the title feat: login with password feat: register or login with email and password Dec 16, 2024
@hyoban hyoban marked this pull request as ready for review December 16, 2024 07:58
- Updated the forget password page to include a back navigation button using MotionButtonBase.
- Refactored the login component to utilize the new Login module, simplifying the structure.
- Adjusted translations for consistency in the login text across English and German locales.
- Improved the useAuthProviders hook to return a more structured AuthProvider interface.

Signed-off-by: Innei <tukon479@gmail.com>
- Introduced form validation state management in forget-password, register, and reset-password components.
- Updated button states to be disabled when forms are invalid, improving user experience.
- Enhanced UI elements with consistent styling and layout adjustments, including the addition of MotionButtonBase for navigation.
- Improved accessibility and responsiveness of card components.

Signed-off-by: Innei <tukon479@gmail.com>
- Added MotionButtonBase for improved button animations and interactions.
- Refactored the rendering logic to conditionally display login options based on the presence of credential providers.
- Introduced a new icon mapping for providers to enhance visual representation.
- Improved layout and styling for better user experience during login.

Signed-off-by: Innei <tukon479@gmail.com>
…onent

- Introduced a GitHub icon to the provider icon map for enhanced visual representation.
- Adjusted the margin of the submit button to improve layout consistency.

Signed-off-by: Innei <tukon479@gmail.com>
@DIYgod DIYgod merged commit 7a6edb4 into dev Dec 16, 2024
10 checks passed
@DIYgod DIYgod deleted the feat/login-with-password branch December 16, 2024 11:13
Innei added a commit that referenced this pull request Dec 16, 2024
* feat: login with password

* chore: auto-fix linting and formatting issues

* feat: show email

* refactor: login form

* chore: update

* fix: show login error

* chore: update

* credential provider

* feat: confirm password

* chore: update

* revokeOtherSessions when update password

* changelog

* typecheck

* chore: update

* chore: update hono

* feat: forget password

* chore: update

* feat: reset password page

* feat: register form

* chore: update

* chore: update

* chore: update

* chore: update

* fix: email login handler

* fix: navigate to login after register

* chore: remove forget password button for now

* chore: update

* feat: forget password page

* chore: update hono

* fix: forget-password link

* feat: login email text

* refactor: enhance login and forget password functionality

- Updated the forget password page to include a back navigation button using MotionButtonBase.
- Refactored the login component to utilize the new Login module, simplifying the structure.
- Adjusted translations for consistency in the login text across English and German locales.
- Improved the useAuthProviders hook to return a more structured AuthProvider interface.

Signed-off-by: Innei <tukon479@gmail.com>

* feat: add form validation and UI enhancements for login-related pages

- Introduced form validation state management in forget-password, register, and reset-password components.
- Updated button states to be disabled when forms are invalid, improving user experience.
- Enhanced UI elements with consistent styling and layout adjustments, including the addition of MotionButtonBase for navigation.
- Improved accessibility and responsiveness of card components.

Signed-off-by: Innei <tukon479@gmail.com>

* feat: enhance login component with dynamic provider buttons

- Added MotionButtonBase for improved button animations and interactions.
- Refactored the rendering logic to conditionally display login options based on the presence of credential providers.
- Introduced a new icon mapping for providers to enhance visual representation.
- Improved layout and styling for better user experience during login.

Signed-off-by: Innei <tukon479@gmail.com>

* feat: add GitHub provider icon and adjust button margin in login component

- Introduced a GitHub icon to the provider icon map for enhanced visual representation.
- Adjusted the margin of the submit button to improve layout consistency.

Signed-off-by: Innei <tukon479@gmail.com>

* chore: update

---------

Signed-off-by: Innei <tukon479@gmail.com>
Co-authored-by: hyoban <hyoban@users.noreply.github.com>
Co-authored-by: DIYgod <i@diygod.me>
Co-authored-by: Innei <tukon479@gmail.com>
Signed-off-by: Innei <tukon479@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub login creates a new account and cannot log in to the previous account
3 participants