Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clicking a media should mark the social media item as read #2297

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

GetToSet
Copy link
Contributor

Description

PR Type

  • Feature
  • Bugfix
  • Hotfix
  • Other (please describe):

Additional context

This PR removes the e.stopPropagation() for the Media in social media items to allow items to be selected and marked as read when clicking the media, same as clicking other parts of the item.

Changelog

  • I have updated the changelog/next.md with my changes.

@follow-reviewer-bot
Copy link

Thank you for your contribution. We will review it promptly.

Copy link

vercel bot commented Dec 22, 2024

@GetToSet is attempting to deploy a commit to the RSS3 Team on Vercel.

A member of the Team first needs to authorize it.

@follow-reviewer-bot
Copy link

Suggested PR Title:

refactor: simplify onClick handlers in social media items

Change Summary:
Refactored onClick handlers for social media items to simplify event handling and enhance readability.

Code Review:
No change requests necessary.

@Innei Innei merged commit 1b0f62f into RSSNext:dev Dec 23, 2024
3 of 6 checks passed
@follow-reviewer-bot
Copy link

Thank you @GetToSet for your contribution! 🎉

Your pull request has been merged and we really appreciate your help in making this project better. We hope to see more contributions from you in the future! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants