Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 2fa #2540

Merged
merged 26 commits into from
Jan 16, 2025
Merged

feat: 2fa #2540

merged 26 commits into from
Jan 16, 2025

Conversation

hyoban
Copy link
Member

@hyoban hyoban commented Jan 10, 2025

Description

enable/disable

ScreenShot.2025-01-14.21.46.38.mp4

sign in with 2fa

ScreenShot.2025-01-14.21.51.29.mp4

operations that require 2fa

ScreenShot.2025-01-14.21.52.56.mp4

PR Type

  • Feature
  • Bugfix
  • Hotfix
  • Other (please describe):

Linked Issues

Additional context

Changelog

  • I have updated the changelog/next.md with my changes.

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
follow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 10:07am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
follow-external-ssr ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 10:07am

@follow-reviewer-bot
Copy link

Suggested PR Title:

feat: add two-factor authentication and enhance password management

Change Summary:
Added two-factor authentication feature with UI components and validation. Improved password update form, and refined translations for better user guidance. Updated dependencies to support new features.

Code Review:
No change requests necessary.

@hyoban hyoban changed the title feat: allow enable and disable 2fa feat: 2fa Jan 10, 2025
@Innei
Copy link
Member

Innei commented Jan 14, 2025

@hyoban can provide screenShot or demo video ?

@Innei
Copy link
Member

Innei commented Jan 14, 2025

@hyoban A few suggestions:

  • After entering 6 digits of the OTP code, immediately check if it is correct, no longer requiring the user to manually submit. If the input is incorrect, shake and prompt "Incorrect code" at the bottom of the input. Then automatically select all the code.

(Submit button can be deleted)

  • Use mono font for the OTP code

@Innei
Copy link
Member

Innei commented Jan 15, 2025

resolves FOL-1474

1 similar comment
@Innei
Copy link
Member

Innei commented Jan 15, 2025

resolves FOL-1474

@hyoban
Copy link
Member Author

hyoban commented Jan 15, 2025

ScreenShot.2025-01-15.22.20.07.mp4

Signed-off-by: Innei <tukon479@gmail.com>
@hyoban hyoban merged commit fb531b1 into dev Jan 16, 2025
8 of 10 checks passed
@hyoban hyoban deleted the feat/2fa branch January 16, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants