Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag --excludePackagesStartingWith [list] #48

Merged
merged 10 commits into from
Dec 2, 2022

Conversation

rhl2401
Copy link
Contributor

@rhl2401 rhl2401 commented Dec 2, 2022

Added a way to exclude packages matching a given string. This is useful for excluding all packages form a specifc vendor or all internal packages that might be prefixed with a specific string, like @<company>/<packagename>which can be excluded alltogether with this flag: --excludePackagesStartingWith '@<company>' instead of adding all packages made by this company to the existing flag --excludePackages

@RSeidelsohn

@RSeidelsohn RSeidelsohn merged commit 87a0266 into RSeidelsohn:master Dec 2, 2022
@RSeidelsohn
Copy link
Owner

Thanks a lot for your contribution!

@rhl2401
Copy link
Contributor Author

rhl2401 commented Dec 2, 2022

Thanks for merging and keeping the repo active!

@rhl2401
Copy link
Contributor Author

rhl2401 commented Dec 2, 2022

@RSeidelsohn Are you planning on publishing on the NPM feed soon aswell? Thank you!

@eugene1g
Copy link
Contributor

eugene1g commented Jan 8, 2023

@RSeidelsohn Would you please cut a fresh release to NPM with this feature? It's super useful to exclude internal company libs that we know are good, without having to list them all individually (e.g., --excludePackagesStartingWith="@myorg/")

@RSeidelsohn
Copy link
Owner

Dear @eugene1g, please be patient - I plan to do it on the upcoming weekend. I know it's a small thing to do, but I need to get my head around it first while working on my full-time job, so I want to be somewhat undistracted by other stuff. Sorry for it taking so long!

@RSeidelsohn
Copy link
Owner

@eugene1g , @rhl2401 , I have released the updated version yesterday, but then (all blame to me as I did not check this beforehand - I definitely should work on this repo more often) discovered a bug in the excludePackagesStartingWith function when using more than one string to exclude. This is now also fixed and released as v3.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants