replaced the judgement of RT_USING_XXX with BSP_USING, and add some… #6554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ips in Konfig about soft_i2c
mysterywolf
requested changes
Oct 24, 2022
| @@ -11,7 +11,7 @@ | |||
| #include <board.h> | |||
| #include "drv_soft_spi.h" | |||
|
|
|||
| #if defined(RT_USING_SPI) && defined(RT_USING_SPI_BITOPS) && defined(RT_USING_PIN) | |||
| #if defined(BSP_USING_I2C1) || defined(BSP_USING_I2C2) | |||
There was a problem hiding this comment.
Suggested change
| #if defined(BSP_USING_I2C1) || defined(BSP_USING_I2C2) | |
| #ifdef BSP_USING_SOFT_I2C |
There was a problem hiding this comment.
本文件的最后一行也需要修改，你看一下其他你修改的地方，应该也有这样的结尾标志注释，如果没有的话请加上
mysterywolf
requested changes
Oct 24, 2022
| @@ -11,7 +11,7 @@ | |||
| #include <board.h> | |||
| #include "drv_soft_spi.h" | |||
|
|
|||
| #if defined(BSP_USING_I2C1) || defined(BSP_USING_I2C2) | |||
| #if defined(BSP_USING_SOFT_I2C) | |||
There was a problem hiding this comment.
Suggested change
| #if defined(BSP_USING_SOFT_I2C) | |
| #ifdef BSP_USING_SOFT_I2C |
mysterywolf
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… tips in Konfig about soft_i2c
拉取/合并请求描述：(PR description)
[
在驱动文件随后被包含，使用BSP_USING进行判断，替换掉了原来的RT_USING判断，并且修改了Kconfig文件，使得在menuconfig的BSP_USING_I2C1配置名称由Enable I2C1 Bus变为Enable I2C1 Bus (software simulation)，并且BSP_USING_I2C2也是如此，已测试过使用此配置能够正常添加驱动文件
]
以下的内容不应该在提交PR时的message修改，修改下述message，PR会被直接关闭。请在提交PR后，浏览器查看PR并对以下检查项逐项check，没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up