Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bsp][lpc55sxx]update: rtconfig.py #7479

Merged
merged 2 commits into from
May 12, 2023
Merged

[bsp][lpc55sxx]update: rtconfig.py #7479

merged 2 commits into from
May 12, 2023

Conversation

Z8MAN8
Copy link
Contributor

@Z8MAN8 Z8MAN8 commented May 11, 2023

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

在什么测试环境下测试通过 (what is the test environment)

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@mysterywolf
Copy link
Member

我知道问题出在哪里了 应该改这里
https://github.com/RT-Thread/rt-thread/pull/7479/files#diff-548bd9fa8f05a081b0275244e7d6ab0fc8e8d697eab046666b1a091a3b4bef14R72

你看一下stm32 armclang这段是怎么写的 lpc55的rtconfig.py里没有对armclang的处理分支

@mysterywolf mysterywolf added the in progress PR/issue in progress. label May 11, 2023
add case of PLATFORM == 'armclang'
@mysterywolf mysterywolf removed the in progress PR/issue in progress. label May 12, 2023
@mysterywolf mysterywolf merged commit a650e3e into RT-Thread:master May 12, 2023
@Z8MAN8 Z8MAN8 deleted the lpc branch May 15, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants