Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DM/feature] Simple NUMA (Non-Uniform Memory Access) #9000

Merged
merged 1 commit into from
May 28, 2024

Conversation

GuEe-GUI
Copy link
Contributor

@GuEe-GUI GuEe-GUI commented May 28, 2024

[
For some CPU memory access devices, that the drivers will find memory and CPU affinity to config device.

Make a way to found the best affinity memory for current CPU (if platform have NUMA memory) or ask the
developers to take care of the memory affinity when driver access a memory:

rt_err_t msi_affinity_init(struct rt_pic_irq *pirq, struct rt_pci_msi_desc *desc, bitmap_t *cpumasks)
{
        rt_uint64_t data_address;

        /* Get MSI/MSI-X write data adddress */
        data_address = desc->msg.address_hi;
        data_address <<= 32;
        data_address |= desc->msg.address_lo;

        /* Prepare affinity */
        cpumasks = pirq->affinity;
        rt_numa_memory_affinity(data_address, cpumasks);

        /* Config affinity */
        return rt_pic_irq_set_affinity(irq, cpumasks);
}

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

For some CPU memory access devices, that the drivers
will find memory and CPU affinity to config device.

Signed-off-by: GuEe-GUI <2991707448@qq.com>
@BernardXiong BernardXiong merged commit 6f6b0c3 into RT-Thread:master May 28, 2024
46 checks passed
@GuEe-GUI GuEe-GUI deleted the upstream-numa branch May 28, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants