Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[smart] update sched_setaffinity() to use thread(task) ID #9004

Merged
merged 1 commit into from
May 28, 2024

Conversation

polarvid
Copy link
Contributor

@polarvid polarvid commented May 28, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

Correct sched_setaffinity() to use the thread IDs (TIDs) instead of
process IDs (PIDs). The previous implementation used PIDs, which
caused issues since affinity settings need to be applied at the
thread level.

As the manual documented, the signature is:

   int sched_setaffinity(pid_t pid, size_t cpusetsize,
                        const cpu_set_t *mask);

Yes, it's tricky, the identification passing in is called 'PID'.
But when we talk about 'pid' from GNU libc, it's the 'task-id',
aka, thread->tid known in kernel.

你的解决方案是什么 (what is your solution)

Changes were made by updating the function signatures and logic
in lwp.h, lwp_pid.c, and lwp_syscall.c to accept TIDs. Specifically,
the lwp_setaffinity function and related internal functions now
operate using thread IDs and adjust thread affinity settings accordingly.

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

Sorry, something went wrong.

@polarvid polarvid marked this pull request as ready for review May 28, 2024 12:21
@polarvid polarvid requested a review from BernardXiong as a code owner May 28, 2024 12:21
Correct `sched_setaffinity()` to use the thread IDs (TIDs) instead of
process IDs (PIDs). The previous implementation used PIDs, which
caused issues since affinity settings need to be applied at the
thread level.

As the manual documented, the signature is:

>        int sched_setaffinity(pid_t pid, size_t cpusetsize,
>                             const cpu_set_t *mask);

Yes, it's tricky, the identification passing in is called **'PID'**.
But when we talk about 'pid' from GNU libc, it's the **'task-id'**,
aka, `thread->tid` known in kernel.

Changes were made by updating the function signatures and logic in
`lwp.h`, `lwp_pid.c`, and `lwp_syscall.c` to accept TIDs. Specifically,
the `lwp_setaffinity` function and related internal functions now
operate using thread IDs and adjust thread affinity settings accordingly

Signed-off-by: Shell <smokewood@qq.com>
@polarvid polarvid force-pushed the shell/set-affinity branch from 529864e to 3e23a87 Compare May 28, 2024 12:32
@BernardXiong BernardXiong merged commit f179ce1 into RT-Thread:master May 28, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants