-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature]更新issue模板,采用议题表单模式 #9011
[feature]更新issue模板,采用议题表单模式 #9011
Conversation
.clang-format
Outdated
@@ -23,7 +23,7 @@ AlignConsecutiveBitFields: | |||
AlignCompound: true | |||
PadOperators: true | |||
AlignConsecutiveDeclarations: | |||
Enabled: false | |||
Enabled: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的修改可以帮忙解释下吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个是clang-format自动格式化的配置,跟issue template这个pr无关,AlignConsecutiveDeclarations表示自动对齐连续的变量定义/声明。在#9008这个pr的中修改ktime代码时,发现部分变量定义手动对齐了,如果AlignConsecutiveDeclarations=disable就会采用单个空格分开类型和变量,也就是变量定义不对齐,因此将.clang-format中对应的AlignConsecutiveDeclarations=enable
components/drivers/ktime/inc/ktime.h
Outdated
@@ -18,13 +18,13 @@ | |||
|
|||
#include "rtthread.h" | |||
|
|||
#define RT_KTIME_RESMUL (1000000UL) | |||
#define RT_KTIME_RESMUL (1000000ULL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
分离来提交,或者是关联到其他的PR了?如果是,把PR号列入吧,可以在对应的PR合并后再合并这份PR。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
该部分修改是解决ktime部分函数计算时unsigned long溢出这个PR的内容,由于我连续提交了两个PR,第一次PR还没有来得及合并。因此这当前的PR中出现了。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
还是重新提交一次吧,thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
重新提交,force-push,只是保留了issue template的部分
242ddf5
to
ee470bb
Compare
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
目前的issue模板,没有提示信息,也没有格式要求。因此每次提交的issue格式千奇百怪,可能没有说到点子上。
你的解决方案是什么 (what is your solution)
根据议题表单,创建了新的BUG和Feature两个issue template,效果如下:
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up