Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]更新issue模板,采用议题表单模式 #9011

Merged

Conversation

ComerLater
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

目前的issue模板,没有提示信息,也没有格式要求。因此每次提交的issue格式千奇百怪,可能没有说到点子上。

你的解决方案是什么 (what is your solution)

根据议题表单,创建了新的BUGFeature两个issue template,效果如下:

issue
bug
feature

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@ComerLater ComerLater changed the title [feature]采用议题表单模式修改issue模板 [feature]更新issue模板,采用议题表单模式 May 30, 2024
.clang-format Outdated
@@ -23,7 +23,7 @@ AlignConsecutiveBitFields:
AlignCompound: true
PadOperators: true
AlignConsecutiveDeclarations:
Enabled: false
Enabled: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的修改可以帮忙解释下吗?

Copy link
Contributor Author

@ComerLater ComerLater May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是clang-format自动格式化的配置,跟issue template这个pr无关,AlignConsecutiveDeclarations表示自动对齐连续的变量定义/声明。在#9008这个pr的中修改ktime代码时,发现部分变量定义手动对齐了,如果AlignConsecutiveDeclarations=disable就会采用单个空格分开类型和变量,也就是变量定义不对齐,因此将.clang-format中对应的AlignConsecutiveDeclarations=enable

@@ -18,13 +18,13 @@

#include "rtthread.h"

#define RT_KTIME_RESMUL (1000000UL)
#define RT_KTIME_RESMUL (1000000ULL)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

分离来提交,或者是关联到其他的PR了?如果是,把PR号列入吧,可以在对应的PR合并后再合并这份PR。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

该部分修改是解决ktime部分函数计算时unsigned long溢出这个PR的内容,由于我连续提交了两个PR,第一次PR还没有来得及合并。因此这当前的PR中出现了。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还是重新提交一次吧,thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

重新提交,force-push,只是保留了issue template的部分

@ComerLater ComerLater force-pushed the feature/add-issue-template branch from 242ddf5 to ee470bb Compare May 31, 2024 07:52
@BernardXiong BernardXiong merged commit b0f460c into RT-Thread:master May 31, 2024
45 checks passed
@ComerLater ComerLater deleted the feature/add-issue-template branch June 25, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants