Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXUP/FEATURE/OFW] OFW API #9411

Merged
merged 7 commits into from
Sep 13, 2024
Merged

[FIXUP/FEATURE/OFW] OFW API #9411

merged 7 commits into from
Sep 13, 2024

Conversation

GuEe-GUI
Copy link
Contributor

@GuEe-GUI GuEe-GUI commented Sep 10, 2024 •
edited
Loading

拉取/合并请求描述：(PR description)

[
Fixup:

  1. Remove rt_ofw_foreach_node_by_compatible args's type.
  2. Increase append child node's ref_count.
  3. Make DTS version header always v1.0.
  4. Remove the last empty string for bootargs.
  5. Fixup ofw_parse_object object find flow.

Feature:

  1. Add bootargs select in early
  2. Add address reverse/translate for DMA/CPU's address

Test:

  • qemu-virt64-aarch64
  • rockchip/rk3568
    ]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@GuEe-GUI
[FIXUP/OFW] rt_ofw_foreach_node_by_compatible args
522fe87 
Signed-off-by: GuEe-GUI <2991707448@qq.com>
@GuEe-GUI
[FIXUP/OFW] Increase append child node's ref_count
93e67ac 
rt_ofw_append_child append a new child node and return,
ref_get is necessary.

Signed-off-by: GuEe-GUI <2991707448@qq.com>
@GuEe-GUI
[FIXUP/OFW] DTS version header always v1.0
99ccf58 
Signed-off-by: GuEe-GUI <2991707448@qq.com>
@GuEe-GUI
[FIXUP/OFW] remove the last empty string for bootargs
4b91fd9 
Signed-off-by: GuEe-GUI <2991707448@qq.com>
@GuEe-GUI
[FIXUP/OFW] ofw_parse_object fail
00ad8c3 
The ofw parse should:
1. Check obj_name EQU the current node's rt_data.
2. Find the next object name.
3. goto "2" until obj_name EQU the cmp_cell's obj_name.

Signed-off-by: GuEe-GUI <2991707448@qq.com>
@GuEe-GUI
[FEATURE/FDT] Add bootargs select in early
9a647bf 
Maybe use for memory/DMA buffer init before
ofw_node unflatten.

Signed-off-by: GuEe-GUI <2991707448@qq.com>
@GuEe-GUI
[FEATURE/OFW] add address reverse/translate for DMA/CPU's address
d725bb7 
DMA and CPU address view is different, we need to convert them:

    +--------+    +--------+  +---------+          +--------+
    |        |    |        |  |         |          |        |
    |  CPUs  |    |  DEV0  |  |  IOMMU  <----+     |  DEV1  |
    |        |    |        |  |         |    |     |        |
    +----+---+    +----+---+  +----+----+    |     +----+---+
         |             |           |         |          |
0x200000 |      0x1000 |    0x1000 |         |   0x8000 |
         |             |           |         |          |
         +-------------+-----------+         +----------+
         |
         |
+--------v----------------------------------------------------+
|                                                             |
|                          Address BUS                        |
|                                                             |
+-------------------------------------------------------------+

Signed-off-by: GuEe-GUI <2991707448@qq.com>
@supperthomas
Copy link
Member

cppcheck错误可以忽略

@mysterywolf mysterywolf merged commit 2d026a3 into RT-Thread:master Sep 13, 2024
43 of 44 checks passed
@GuEe-GUI GuEe-GUI deleted the fixup_ofw branch October 22, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supperthomas supperthomas supperthomas approved these changes

@polarvid polarvid polarvid approved these changes

@Rbb666 Rbb666 Awaiting requested review from Rbb666

Assignees
No one assigned
Labels
Component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuEe-GUI @supperthomas @polarvid @mysterywolf