-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S32K344 Basic porting : FINSH #9544
base: master
Are you sure you want to change the base?
Conversation
|
我建议命名成 bsp/nxp/s32/s32k344-core 文件夹名称可以用中划线 |
ci加一下。在.github/workflow/bsp_building.yml |
好的,更改了 |
4bdca1c
to
a7fa3a7
Compare
麻烦把此ci加一下。在.github/workflow/bsp_building.yml中,添加此BSP |
@PillarShi CI方便加下吗? |
C build/board/board.o 56 scons: *** [build/applications/main.o] Error 1 57 In file included from board/board.c:11: 58 board/board.h:16:10: fatal error: S32K344.h: No such file or directory 59 16 | #include "S32K344.h" 60 | ^~~~~~~~~~~ 61 compilation terminated. 62 scons: *** [build/board/board.o] Error 1 |
为啥要移除? |
可以只放编译需要的文件 |
NXP这里的生成的代码是有许可证问题,考虑到这个是不是最好不要放上来?那么ci就只能做检查,不能编译 同时目前这个版本可能要再改动一下,做到更好的适配 |
可以考虑制作软件包的方式,参考nrf5x/nrf52840 |
拉取/合并请求描述:(PR description)
适配S32K344的基础工程,对LPUART采用寄存器控制,实现FINSH的移植,同时每两秒打印hello验证调度和延时的正确
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up