-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bsp][at32] can bus CAN_RX_FIFO defined twice #9611
Draft
koendv
wants to merge
1
commit into
RT-Thread:master
Choose a base branch
from
koendv:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koendv
force-pushed
the
master
branch
2 times, most recently
from
November 12, 2024 19:59
1df738b
to
45330bd
Compare
10 tasks
@wdfk-prog 看看可否提个PR修改一下这个问题,这个宏当时是您引入进来的,本PR的修改方式肯定是不对的。 |
|
|
OK 我重新提交PR处理一下 @koendv Thanks for your PR, I will re-implement the PR and submit it. I will close this PR. Thank you~ |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
Compilation of CAN device on AT32 fails. CAN_RX_FIFO0 and CAN_RX_FIFO1 are defined twice.
Once in components/drivers/include/drivers/dev_can.h, as a #define.
Once in bsp/at32/libraries/AT32F435_437_Firmware_Library/drivers/inc/at32f435_437_can.h, as an enum.
Hence, compilation fails.
你的解决方案是什么 (what is your solution)
In at32f435_437_can.h, undefine CAN_RX_FIFO0 and CAN_RX_FIFO1
If others have encountered the same problem, I would like to know how they solved it.
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up