Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cvitek] fix when using rt_smart CLK_EN_0 have no ioremap #9664

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhuzhuzhus
Copy link
Contributor

@zhuzhuzhus zhuzhuzhus commented Nov 18, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added BSP BSP: Cvitek BSP related with cvitek labels Nov 18, 2024
@zhuzhuzhus
Copy link
Contributor Author

zhuzhuzhus commented Nov 18, 2024

@flyingcys#9657 漏了一个ioremap 这里添加上了

@unicornx unicornx self-requested a review November 18, 2024 12:58
@unicornx unicornx added the Arch: RISC-V BSP related with risc-v label Nov 18, 2024
@unicornx
Copy link
Contributor

@flyingcys#9657 漏了一个ioremap 这里添加上了

@zhuzhuzhus#9657 没有 merge 之前,你直接给他提 review comment 就好了。我已经在 review #9657 时请 @flyingcys merge 你的改动了。等 #9657 merge 后,确认已包含你的改动后,这个 PR 可以直接关掉。

Thanks,
Chen

@zhuzhuzhus
Copy link
Contributor Author

@flyingcys#9657 漏了一个ioremap 这里添加上了

@zhuzhuzhus#9657 没有 merge 之前,你直接给他提 review comment 就好了。我已经在 review #9657 时请 @flyingcys merge 你的改动了。等 #9657 merge 后,确认已包含你的改动后,这个 PR 可以直接关掉。

Thanks, Chen

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: RISC-V BSP related with risc-v BSP: Cvitek BSP related with cvitek BSP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants