ENH: Add variance reconstruction for FDK #632
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonRit
requested changes
Nov 8, 2024
There was a problem hiding this comment.
Thanks for taking care of this overdue PR. A few comments:
- The command line application is wrong for short scans and displaced detector as you do not square the weights. I would suggest to at least remove them. Are you sure the command line application should be kept? Maybe a Python command line application is sufficient?
- There is also a test failing: https://my.cdash.org/viewTest.php?onlyfailed&buildid=2717834
- I would try make the test even faster, maybe 10 projections only? It does not really matter, does it?
arobert01
force-pushed
the
variance-recon
branch
from
136a3a4 to
67665f8
Compare
|
Thanks for your comments. In the last force-pushed I deleted the application, fixed the failed test and modified the test to be faster. |
The new FFTVarianceRampImageFilter uses modified FFTRampImageFilter and FDKWeightProjectionFilter.
arobert01
force-pushed
the
variance-recon
branch
from
67665f8 to
5eaf02c
Compare
|
With the last force-pushed I implemented the idea in the first part of this comment to avoid code repetition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.