-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UMLS Conversion Script (Multi Ont) Fails #300
Comments
This link (https://raw.githubusercontent.com/biolink/biolink-model/3.1.2/biolink-model.owl.ttl) is no longer valid. Also, @acevedol and @saramsey, is it correct that we are on Biolink version 3.1.2? This is what the issue-263 and issue-263-local branch have in their master-config.shinc files (linked) as well. |
With 4358a2f and 23e1f4b, the Biolink model URL resolves. However, these errors (far more than these listed, but these are an example) are popping up:
These don't cause script failure, but they seem undesireable. |
Here's the new script failing error, though:
|
New failure point:
This relates to #236. |
After attempting to fix this by reverting back to
|
Here is the error that command returns:
(I am confident the command is correct because it completes successfully on |
The fix used in #236 isn't going to work again, since the
I think this is related to the Food Ontology's Issue Number 275. |
Here is documentation on Here is documentation on Here is a discussion of the same error message. It sounds like the problem is that they are not part of the same hierarchy, so one can't be cast to the other. My next step is going to be to try and track down where these different properties show up in the source file so that I can report it to the Food Ontology to be fixed. |
Based on #303, I switched to a
This is weird because biolink is first in the I think this is because of 4f7a1e2#diff-3a03aca522a201f93e621bc75bdea21a1e34525350f60392470aaf10a5bbdcebL130-R130 |
In the interest of minimizing pain in future builds, I wonder if we should loosen up that assertion to just search for substring "biolink-model" in the URL? The Biolink w3id URL seems to change from time to time. |
That is probably a good idea. I corrected it enough (in I also want to note my concern with the current state of
|
Nevermind my concern with LOINC. Based on the previous build on
|
That leaves me to wonder, is LOINC worth it? I will ask around. |
New error:
|
9846346 addressed that previous error. There is a new error:
I suspect we need to address a larger, upstream issue that is creating these lists. |
Erica, using the current version (2020-04-06) of
|
I am closing this issue because the code worked in |
While testing for #296, I found that multi_ont_to_json_kg.py fails:
The text was updated successfully, but these errors were encountered: