Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RTXFeedback #2304

Closed
edeutsch opened this issue Jul 3, 2024 · 2 comments
Closed

Remove RTXFeedback #2304

edeutsch opened this issue Jul 3, 2024 · 2 comments
Assignees

Comments

@edeutsch
Copy link
Collaborator

edeutsch commented Jul 3, 2024

Long ago we had a nifty Feedback mechanism for ARAX, but hardly anyone used it and other parts of the code were moving fast. So it was deprecated in favor of ResponseCache, which grew out of RTXFeedback. I thought RTXFeedback was completely gone, but apparently it was still collecting dust in the garage.

It should be fully removed and all references to it scrubbed. For example, this part of the code still mentions it:

from ARAX_messenger import ARAXMessenger
messenger = ARAXMessenger()
if not params.local:
print("INFO: Fetching message to work on from arax.ncats.io", flush=True)
message = messenger.fetch_message('https://arax.ncats.io/api/rtx/v1/message/2614') # acetaminophen - > protein, just NGD as virtual edge
# message = messenger.fetch_message('https://arax.ncats.io/api/rtx/v1/message/2687') # neutropenia -> drug, predict_drug_treats_disease and ngd
# message = messenger.fetch_message('https://arax.ncats.io/api/rtx/v1/message/2701') # observed_expected_ratio and ngd
# message = messenger.fetch_message('https://arax.ncats.io/api/rtx/v1/message/2703') # a huge one with jaccard
# message = messenger.fetch_message('https://arax.ncats.io/api/rtx/v1/message/2706') # small one with paired concept frequency
# message = messenger.fetch_message('https://arax.ncats.io/api/rtx/v1/message/2709') # bigger one with paired concept frequency
# For local messages due to local changes in code not rolled out to production:
if params.local:
sys.path.append(os.path.dirname(os.path.abspath(__file__)) + "/../../UI/Feedback")
from RTXFeedback import RTXFeedback
araxdb = RTXFeedback()
message_dict = araxdb.getMessage(294) # local version of 2709 but with updates to COHD

@edeutsch
Copy link
Collaborator Author

Removed with commit 4dcd43b
Removed with commit a68158b

@edeutsch
Copy link
Collaborator Author

All tests passing. Ancient RTXFeedback code is now all removed.
Most of its relevant functionality was replaced with ResponseCache long ago.
closing. Please reopen is you detect a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant