CodeQL multiple.ql EFanntenna.c DBResidueMask() call sites

TileTypeBitMask *DBResidueMask(TileType type);
/* NOTE: candidate for using a const return */

TooManyArguments.ql EFantenna.c DBResidueMask() calls with too many args
????????.ql EFantenna. DBResidueMask() called but function return discarded
 and call has no side-effect ([[nodiscard]] candidate in C++ parlance)

This patch fixes the calling arguments to the use of DBResidueMask()
without removing the call completely (as an assessment of original
intention should be made to confirm correctness) but
this method is a access method to retrieve the residue mark

Added __nodiscard__ to function to compiler can help identify sooner

database/database.h.in

@@ -900,7 +900,7 @@ extern TileType DBTechFindStacking();
 extern bool DBIsContact();
 extern PlaneMask DBLayerPlanes();
 
-extern TileTypeBitMask *DBResidueMask();
+extern __nodiscard__ TileTypeBitMask *DBResidueMask(TileType type);
 extern void DBFullResidueMask();
 
     /* Miscellaneous */

extflat/EFantenna.c

@@ -872,7 +872,10 @@ antennaAccumFunc(tile, aaptr)
 	    {
 		if (type >= DBNumUserLayers)
 		{
-		    DBResidueMask(type, &sMask);
+		    /* FIXME: Remove this redundant call to DBResidueMask() ? */
+		    /* Maybe the intention was: DBFullResidueMask(type, &sMask); */
+		    /* But it has been called above and the sMask does not look to have been modified since */
+		    const TileTypeBitMask *tmp = DBResidueMask(type); /* tmp unused, DBResidueMask() has no side-effects */
 		    for (ttype = TT_TECHDEPBASE; ttype < DBNumTypes; ttype++)
 			if (TTMaskHasType(&sMask, ttype))
 			    if (DBTypeOnPlane(ttype, plane))
@@ -983,7 +986,10 @@ antennaAccumFunc(tile, aaptr)
 
 	    if (type >= DBNumUserLayers)
 	    {
-		DBResidueMask(type, &sMask);
+		/* FIXME: Remove this redundant call to DBResidueMask() ? */
+		/* Maybe the intention was: DBFullResidueMask(type, &sMask); */
+		/* But it has been called above and the sMask does not look to have been modified since */
+		const TileTypeBitMask *tmp = DBResidueMask(type); /* tmp unused, DBResidueMask() has no side-effects */
 		for (ttype = TT_TECHDEPBASE; ttype < DBNumTypes; ttype++)
 		    if (TTMaskHasType(&sMask, ttype))
 			if (DBTypeOnPlane(ttype, plane))