Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add multi behavior dataset #43

Merged
merged 6 commits into from
Jun 15, 2022
Merged

[Feature] Add multi behavior dataset #43

merged 6 commits into from
Jun 15, 2022

Conversation

Tokkiu
Copy link
Contributor

@Tokkiu Tokkiu commented Jun 15, 2022

Fix #42 @hyp1231
Add implementation of the multi-behavior dataset.
Plz check it if any could be improved

@Tokkiu Tokkiu mentioned this pull request Jun 15, 2022
Closed
hyp1231
hyp1231 reviewed Jun 15, 2022
View reviewed changes
@Tokkiu
Copy link
Contributor Author

Tokkiu commented Jun 15, 2022

@hyp1231 Thanks for your kind comments! It makes sense and I have fixed them all while testing to construct a multi-behavior dataset.
Plz, check the newest version.

hyp1231
hyp1231 reviewed Jun 15, 2022
View reviewed changes
Copy link
Member

@hyp1231 hyp1231 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your quick reply! I still have one concern which is listed below.

@Tokkiu
Copy link
Contributor Author

Tokkiu commented Jun 15, 2022

Thanks for your quick reply! I still have one concern which is listed below.

Yes, You're right! I fixed it, haha.

hyp1231
hyp1231 approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@hyp1231 hyp1231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks for the great efforts. :)

@hyp1231 hyp1231 merged commit a757bb7 into RUCAIBox:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyp1231 hyp1231 hyp1231 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[💡SUG] Multi behavior dataset usage
2 participants
@Tokkiu @hyp1231