Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: fix the bug in negative sampling. #1876

Merged
merged 1 commit into from
Sep 23, 2023
Merged

FIX: fix the bug in negative sampling. #1876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion recbole/data/dataloader/abstract_dataloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def _set_neg_sample_args(self, config, dataset, dl_format, neg_sample_args):
self.times = 1
if (
self.neg_sample_args["distribution"] == "uniform"
or "popularity"
or self.neg_sample_args["distribution"] == "popularity"
and self.neg_sample_args["sample_num"] != "none"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zhengbw0324,

This fix is still incorrect. When distribution is uniform, the if condition always returns True no matter what sample_num is.

So I suggest using the method mentioned in the PR:#1863.
Or you can put the self.neg_sample_args["distribution"] == "uniform" or self.neg_sample_args["distribution"] == "popularity" into a parenthesis, i.e.,

if (
      ( self.neg_sample_args["distribution"] == "uniform" 
        or self.neg_sample_args["distribution"] == "popularity" )     # <- like this
        and self.neg_sample_args["sample_num"] != "none"
):
    ...

Thanks!

):
self.neg_sample_num = self.neg_sample_args["sample_num"]
Expand Down