Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue1122 air exchange boolean #1190

Merged
merged 21 commits into from
Jun 13, 2022
Merged

Issue1122 air exchange boolean #1190

merged 21 commits into from
Jun 13, 2022

Conversation

larissakuehn
Copy link
Contributor

@larissakuehn larissakuehn commented Oct 29, 2021 •
edited
Loading

Issue #1122 is solved by replacing use_AirExchange by two booleans:

  • use_NaturalAirExchange
  • use_MechanicalAirExchange

@larissakuehn
Merge remote-tracking branch 'origin/issue1172_MixedHumidity' into is…
fc876bb 
…sue1122_AirExchangeBoolean
@larissakuehn
6a65706 
include changes from issue 1172 [skip ci] #1122
@larissakuehn
replace use_AirExchange by use_NaturalAirExchange and use_MechanicalA…
cbb5488 
…irExchange [skip ci] #1122
@larissakuehn
0e572bc 
add missing connections for case where only mechnaical ventilation is active [skip ci] #1122
@larissakuehn
9614871 
Add parameter use_NaturalAirExchange and use_MechanicalAirExchange in PartialMultizone [skip ci] #1122
@larissakuehn
Merge remote-tracking branch 'origin/issue1122_AirExchangeBoolean' in…
42ea98d 
…to issue1122_AirExchangeBoolean
@larissakuehn
ce6d29b 
small changes in graphical view [skip ci] #1122
@larissakuehn
Merge remote-tracking branch 'origin/issue1172_MixedHumidity' into is…
36d3988 
…sue1122_AirExchangeBoolean
@larissakuehn larissakuehn self-assigned this Oct 29, 2021
@larissakuehn larissakuehn linked an issue Oct 29, 2021 that may be closed by this pull request
AirExchange in records are not regarded if use_AirExchange is not used. #1122
Closed
@larissakuehn
#1122 use_NaturalAirExchange depended on baseACH within zoneParams [s…
a18784e 
…kip ci]
@larissakuehn
Merge remote-tracking branch 'origin/development' into issue1122_AirE…
2db3d05 
…xchangeBoolean
@larissakuehn
Merge branch 'development' into issue1122_AirExchangeBoolean
30d8c36
@larissakuehn
1fb7698 
#1122 default for natural infiltration equals default for mechanical ventilation for conversion [scip ci]
@larissakuehn
cf25f51 
#1122 Correct connections [scip ci]
@larissakuehn
e528925 
#1122 Change affected examples [scip ci]
@larissakuehn
#1122 add conversion script
12c99e9
@larissakuehn
Merge remote-tracking branch 'origin/issue1122_AirExchangeBoolean' in…
5cf8fa5 
…to issue1122_AirExchangeBoolean
@larissakuehn
c0f9b5a 
#1122 fix errors in multizone and apply equivalent changes as in thermal zone
FWuellhorst
FWuellhorst requested changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@FWuellhorst FWuellhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Prior to a functional check, some style changes :)

FWuellhorst
FWuellhorst approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@FWuellhorst FWuellhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! Thanks for the nice work :)

@larissakuehn larissakuehn merged commit 5e96627 into development Jun 13, 2022
@larissakuehn larissakuehn deleted the issue1122_AirExchangeBoolean branch June 13, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FWuellhorst FWuellhorst FWuellhorst approved these changes

Assignees

@larissakuehn larissakuehn

Labels
hackday
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AirExchange in records are not regarded if use_AirExchange is not used.
2 participants
@larissakuehn @FWuellhorst