Add new output connector to thermalZones and post processing #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaJansenGit
requested changes
Feb 25, 2022
AixLib/ThermalZones/ReducedOrder/Multizone/BaseClasses/MultizonePostProcessing.mo
Outdated
Show resolved
Hide resolved
AixLib/ThermalZones/ReducedOrder/Multizone/BaseClasses/MultizonePostProcessing.mo
Outdated
Show resolved
Hide resolved
AixLib/ThermalZones/ReducedOrder/Multizone/BaseClasses/PartialMultizone.mo
Outdated
Show resolved
Hide resolved
…the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1215_internalGainsOuput/plots/ [skip ci]
DaJansenGit
previously approved these changes
Feb 25, 2022
DaJansenGit
dismissed
their stale review
sry, need to cancel approve. CI found errors.
added 3 commits
March 16, 2022 08:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1215
@DaJansenGit : I tried to use the
AixLib.ThermalZones.ReducedOrder.Multizone.BaseClasses.MultizonePostProcessingtool but got singularities. Could you try on your code? I did not find any usage of this model.Overall, I really disliked the multizone concept, the array handling is somewhat confusing. If the array approach (numZones, 3) is not in line with our guidelines I can change it.