Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1217 slack git hub action #1293

Merged
merged 6 commits into from
Jun 2, 2022

Conversation

SvenHinrichs
Copy link
Contributor

Thank you for making a Pull Request to AixLib!

Please consider these points before submitting:

  • Mention the issue that this Pull Request intends to solve, and briefly describe what the main changes are.
  • Make sure all new code follows our Modelica Guidelines
  • Make sure all new models include documentation as described in the Documentation Wiki-Page and are demonstrated by suitable examples

If you know someone who could review your code, please use the Reviewer function on the right to ask for a review and also assign the PR to them. If not, no worries, we will find someone for you.

Thanks again for your PR! You can delete these first lines before submitting your PR.

@SvenHinrichs SvenHinrichs requested a review from DaJansenGit May 24, 2022 08:15
@SvenHinrichs SvenHinrichs self-assigned this May 24, 2022
Copy link
Member

@DaJansenGit DaJansenGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the implementations :) If the CI passes you can merge!

@SvenHinrichs SvenHinrichs merged commit f6996df into development Jun 2, 2022
@SvenHinrichs SvenHinrichs deleted the Issue1217_Slack_GitHubAction branch June 2, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants