-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed TStart for BufferStorage and Storage to an array #1305
Conversation
Also changed the examples for BufferStorage. The changes in Storage are not testet yet.
@tobinfiedler reminder |
@tobinfiedler, @tosch4, any updates on this? |
@LauraMaier : I added the requested changes and triggered the CI to see if the result changes as expected. I will update the failing CI ones the plot confirms the correct implementation. Please check my others comments and re-review. |
Thank you for making a Pull Request to AixLib! Our CI pipeline will help you finalize your contribution.
If HTML errors occur, I will fix the issues using a separate pull request. Tips to fix possible naming violations:
If all CI stages pass and you have addressed possible naming violations, please consider the following:
Once you have addressed these points, you can assign a reviewer. If you have any questions or issues, please tag a library developer. |
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/AixLib/issue1224_initial_layer_values_storage/charts |
1 similar comment
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/AixLib/issue1224_initial_layer_values_storage/charts |
…ub.com/RWTH-EBC/AixLib into issue1224_initial_layer_values_storage
…ion reference files. Please pull the new files before push again. Plottet Results /issue1224_initial_layer_values_storage/charts/
…ub.com/RWTH-EBC/AixLib into issue1224_initial_layer_values_storage
…ion reference files. Please pull the new files before push again. Plottet Results /issue1224_initial_layer_values_storage/charts/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI works now
Also changed the examples for BufferStorage. The changes in Storage are not testet yet.