Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue1297 fluid ports hom #1334

Merged
merged 9 commits into from
Sep 13, 2022
Merged

Issue1297 fluid ports hom #1334

merged 9 commits into from
Sep 13, 2022

Conversation

larissakuehn
Copy link
Contributor

Adding fluid ports to all zones of the OFD (HOM), except of the attic. P

orts are optional to be enabled in existing examples to avoid errors.

@larissakuehn
d3f9006 
#1297 Add fluid ports and propagate medium for air volume
@larissakuehn
ab1e3f5 
#1297 add medium within examples and validation models
@larissakuehn
04d1d00 
#1297 make fluid ports for HOM optional to avoid errors within examples and remove fluid port for attic
@larissakuehn
Merge remote-tracking branch 'origin/development' into issue1297_flui…
a7c56fb 
…dPortsHOM
@larissakuehn larissakuehn self-assigned this Sep 6, 2022
FWuellhorst
FWuellhorst requested changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@FWuellhorst FWuellhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feature! Please check my comments :)

fabian.wuellhorst and others added 5 commits September 12, 2022 15:51
add 11
e676b41
@larissakuehn
d1dcc23 
#1297 revert changed within connections
@larissakuehn
#1297 reverse changes within connections
92e5041
@larissakuehn
f16ef3a 
#1297 reverse changes within connections
@larissakuehn
Merge remote-tracking branch 'origin/issue1297_fluidPortsHOM' into is…
9dce304 
…sue1297_fluidPortsHOM
FWuellhorst
FWuellhorst approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@FWuellhorst FWuellhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!!

@larissakuehn larissakuehn merged commit 4a8f4ea into development Sep 13, 2022
@larissakuehn larissakuehn deleted the issue1297_fluidPortsHOM branch September 13, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FWuellhorst FWuellhorst FWuellhorst approved these changes

Assignees

@larissakuehn larissakuehn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larissakuehn @FWuellhorst