Correctly handle GCS paths that contain '?' char #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move _safe_urlsplit to utils and used it from s3 and gcs implementations to support paths with '?' character
mpenkov
approved these changes
Apr 4, 2020
|
Good catch, thank you! And congratulations on your first PR to smart_open! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly handle GCS paths that contain '?' char
Motivation
GCS (and s3) paths support the character '?' . Use of urllib.parse.urlsplit was splitting the path at '?' due to which such files cannot be opened. This was already handled for S3 paths correctly.
Moved the existing utility function in s3 to utils so that it can be called from both s3 and gcs implementations.
Checklist
Before you create the PR, please make sure you have: