Remove boto as a dependency #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: - piskvorky#391 - piskvorky#409 Related to: - piskvorky#413 - piskvorky#468 - piskvorky#408
mpenkov
reviewed
Jul 22, 2020
piskvorky
reviewed
Aug 26, 2020
isobit
force-pushed
the
feature/20200720-remove-boto-dependency
branch
from
9a48675 to
2e96179
Compare
…-remove-boto-dependency
|
Thank you for your contribution and your patience @isobit ! And congrats on your first PR to smart_open 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Related to:
smart_open.s3.iter_bucketbecause of missingbotodependancy. #468