Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove boto entirely #409

Closed
mpenkov opened this issue Jan 12, 2020 · 0 comments
Closed

Remove boto entirely #409

mpenkov opened this issue Jan 12, 2020 · 0 comments
Labels
housekeeping issues for the smart_open team to deal with internally

Comments

@mpenkov
Copy link
Collaborator

mpenkov commented Jan 12, 2020

We don't really need boto, IMHO. It's entirely separate to boto3.

Let's remove it in a separate PR.

Originally posted by @mpenkov in #408
@mpenkov mpenkov added the housekeeping issues for the smart_open team to deal with internally label Apr 25, 2020
isobit added a commit to isobit/smart_open that referenced this issue Jul 20, 2020
@isobit
Remove boto as a dependency
ecce29e 
Fixes:
- piskvorky#391
- piskvorky#409

Related to:
- piskvorky#413
- piskvorky#468
- piskvorky#408
@isobit isobit mentioned this issue Jul 20, 2020
Merged
mpenkov added a commit that referenced this issue Aug 30, 2020
@isobit @mpenkov
Remove boto as a dependency (#523)
399e30e 
* Remove boto as a dependency

Fixes:
- #391
- #409

Related to:
- #413
- #468
- #408

* Remove old boto tests and remove boto as test dependency

* Remove mention of boto from README as tests are no longer in place

* update CHANGELOG.md

Co-authored-by: Michael Penkov <misha.penkov@gmail.com>
@mpenkov mpenkov closed this as completed Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
housekeeping issues for the smart_open team to deal with internally
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mpenkov