Change python_requires version to fix PEP 440 issue #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks – duplicate of #631. Although this PR looks more articulate. |
mpenkov
changed the title
mpenkov
changed the title
|
Merged. Thank you @lucasvieirasilva !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Fix
python_requiresto use PEP 440 Version IdentificationMotivation
This PR changes the
python_requiresproperty in thesetup.pyversion to follow the PEP 440 Version Identification, which will be able to install this package usingpoetryversion1.2.0a2, which validates the PEP 440 as part of the installation process.Tests
No new unit tests are required.
Checklist
Before you create the PR, please make sure you have:
Included tests for any new functionalityWorkflow
Please avoid rebasing and force-pushing to the branch of the PR once a review is in progress.
Rebasing can make your commits look a bit cleaner, but it also makes life more difficult from the reviewer, because they are no longer able to distinguish between code that has already been reviewed, and unreviewed code.