Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python version specification #631

Closed
wants to merge 2 commits into from
Closed

Conversation

adriangb
Copy link

@adriangb adriangb commented Jul 31, 2021

Changes >=3.6.* to >=3.6.0 since >=3.6.* is not PEP 440 compliant.

Fixes #638.

Changes >=3.6.* to >=3.6.0 since >=3.6.* is not PEP 440 compliant
@adriangb
Copy link
Author

@piskvorky thank you for running CI.

I don't see how this change would cause CI failures, is it possible that CI is broken? It looks like the last commit to the trunk was several months ago, so I don't have a recent passing CI run to compare against.

@piskvorky
Copy link
Owner

@adriangb I don't know either; let's wait for @mpenkov 's review.

@mpenkov
Copy link
Collaborator

mpenkov commented Aug 12, 2021

Not sure what the problem is here. Let me re-run all the test jobs to see if it was some sort of temporary issue.

@adriangb
Copy link
Author

@mpenkov any input into the CI issues? It'd be nice to get this + a release out as soon as possible.

@mpenkov
Copy link
Collaborator

mpenkov commented Aug 18, 2021

Yes, we're working on it in #633. I'll try to get this merged this week.

@mpenkov
Copy link
Collaborator

mpenkov commented Aug 18, 2021

Closing in favor of #639.

@adriangb Thank you for your work! I'm going to merge a separate PR because it uses a slightly stricter (and in my opinion, better) check.

@mpenkov mpenkov closed this Aug 18, 2021
@adriangb adriangb deleted the patch-1 branch August 18, 2021 03:39
@adriangb
Copy link
Author

Sounds good to me as long as it's fixed. I was just trying to make it as similar to the current check as possible.

@mpenkov
Copy link
Collaborator

mpenkov commented Aug 18, 2021

OK. I'll try to do a release later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PEP 440 Complains when using Poetry tooling
4 participants