Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Sonic Ecology Entry #2619

Merged
merged 21 commits into from
Nov 28, 2024
Merged

feat: Sonic Ecology Entry #2619

merged 21 commits into from
Nov 28, 2024

Conversation

christianholman
Copy link
Contributor

No description provided.

@christianholman
Copy link
Contributor Author

Couple of things to clarify:

  • Am I adding the chain metadata correctly?
  • Are there any places I'm re-doing things that are already util functions, such as fetching and caching?

@christianholman christianholman marked this pull request as ready for review November 12, 2024 12:25
@christianholman christianholman marked this pull request as draft November 12, 2024 12:27
vvvvvv1vvvvvv
vvvvvv1vvvvvv reviewed Nov 12, 2024
View reviewed changes
.envrc Outdated Show resolved Hide resolved
@christianholman christianholman marked this pull request as ready for review November 12, 2024 22:04
@christianholman christianholman marked this pull request as draft November 12, 2024 22:04
vvvvvv1vvvvvv
vvvvvv1vvvvvv reviewed Nov 14, 2024
View reviewed changes
src/utils/index.ts Outdated Show resolved Hide resolved
@christianholman christianholman marked this pull request as ready for review November 14, 2024 10:52
vvvvvv1vvvvvv
vvvvvv1vvvvvv reviewed Nov 20, 2024
View reviewed changes
src/ui/assets/ecology/sonic/points-bg.png Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to compress this image using TinyPng?
tried and can be compress to about 90kb

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, will do

vvvvvv1vvvvvv
vvvvvv1vvvvvv reviewed Nov 20, 2024
View reviewed changes
src/utils/index.ts Outdated Show resolved Hide resolved
@vvvvvv1vvvvvv vvvvvv1vvvvvv merged commit e32d05a into RabbyHub:develop Nov 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvvvvv1vvvvvv vvvvvv1vvvvvv vvvvvv1vvvvvv approved these changes

@cs1707 cs1707 cs1707 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christianholman @cs1707 @vvvvvv1vvvvvv