feat: Sonic Ecology Entry #2619
Conversation
|
Couple of things to clarify:
|
.envrc
Outdated
| @@ -0,0 +1 @@ | |||
| use flake | |||
There was a problem hiding this comment.
Can remove all flake related code? I don't see any real use for it.
.vscode/extensions.json
Outdated
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "recommendations": ["dbaeumer.vscode-eslint"] | |||
| } | |||
There was a problem hiding this comment.
please remove auto-generated code from your vscode
There was a problem hiding this comment.
Neither the flake file nor the ide extension metadata are autogenerated, they're very helpful to get productive without running into a bunch of linting errors etc when the editors are not aware of what sort of codebase is being dealt with, as well as for being able to switch between eslint/non-eslint repos. The flake stuff is for running a shell with node/yarn available, very useful for running an isolated dev environment inside the repo.
Just for some context on why I used them here, nothing overrides the user's editor setup an are just hints if they have no formatting etc to align with your eslint rules!
Will remove them for now and can merge them back again if you see the value :)
src/ui/utils/useCopy.tsx
Outdated
| const [hasCopied, setHasCopied] = useState(false); | ||
| const { t } = useTranslation(); | ||
|
|
||
| const copyToClipboard = async (text: string, options: CopyOptions = {}) => { |
There was a problem hiding this comment.
src/utils/index.ts
Outdated
| @@ -79,3 +79,14 @@ export const safeJSONParse = (str: string) => { | |||
| return null; | |||
| } | |||
| }; | |||
|
|
|||
| export const formatAddress = (address?: string, n = 4) => { | |||
There was a problem hiding this comment.
maybe you can use https://github.com/RabbyHub/Rabby/blob/develop/src/ui/utils/address.ts#L1 for instead?
There was a problem hiding this comment.
for sure, thanks for pointers
No description provided.