This repository has been archived by the owner on Mar 21, 2019. It is now read-only.
Sorted table #6
Merged
Sorted table #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [rows sort-fns by-key] | ||
| (if (contains? sort-fns by-key) | ||
| ((by-key sort-fns) by-key rows) | ||
| ((:default sort-fns) by-key rows))) |
There was a problem hiding this comment.
Is this intentionally still here?
There was a problem hiding this comment.
What do you mean by this?
There was a problem hiding this comment.
sort-rows; since the rest of this PR no longer cares about sorting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
get-all-keysandsort-rows. Those will be used to implement sorting and cols-toggler on the table. Should we add example use of those fns with table to the readme?Also, most common use case would be to add an
on-clickhandler to a table's headers to implement sorting. There are some visual changes involved then that should indicate to the user what's happening (by which column sorting currently happens, is it ascending or descending?). I wonder if we should styles for that inside Wilson?