Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests for all supported python and django versions #225

Closed
abhiabhi94 opened this issue Aug 18, 2021 · 0 comments · Fixed by #226
Closed

Run tests for all supported python and django versions #225

abhiabhi94 opened this issue Aug 18, 2021 · 0 comments · Fixed by #226
Labels
bug Something isn't working codebase

Comments

@abhiabhi94
Copy link
Collaborator

Change Type

[ ] Refactor/Enhancement
[ x] Testing
[ ] CI/CD
[ ] Other

Proposed Changes

As of now, we run tests only for the latest and oldest supported python and Django versions. This might not be ideal in every case, because something that might work on Django 3.2 doesn't necessarily work on 3.1 because 3.2 is LTS(long term support) so patches are still back ported to it. Whereas 3.1 is in freeze mode and hence it does no longer receive back ports.

Similarly, for 2.1 and 2.2(LTS).

In order to not get caught in a situation where a test failure wouldn't be caught by our test suite, I think we should run them on all supported python and Django versions. I understand that we had made this choice to run only on some versions earlier to reduce the testing time. A lot on this front has been taken care now that tests run in fairly less amount of time and tests for different versions can be run parallelly(if this is not true on travis, maybe we can switch to GitHub actions).

Also, i found that we don't run the tests on Django 3.2 on travis, this was probably missed in e171d8f. This too can be handled in this.

This is also blocking #220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant