Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#153): Add support for rendering content in markdown format #222

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

abhiabhi94
Copy link
Collaborator

@abhiabhi94 abhiabhi94 commented Aug 18, 2021

resolves #153

@abhiabhi94
Copy link
Collaborator Author

The test failures from travis seem weird to me at the moment. 😞

tox passes locally for me. Seeing the logs, I think the tests are probably not being run on the latest version of this branch.

@abhiabhi94 abhiabhi94 force-pushed the feat/add-markdown branch 2 times, most recently from e1ab5ab to 170ebd0 Compare August 18, 2021 22:22
@abhiabhi94
Copy link
Collaborator Author

abhiabhi94 commented Aug 18, 2021

okay, got it, the test failures are from Django 2.1, didn't run tox locally on it.

So the failures on 2.1 is due to the bug. it has been fixed in django/django@e3d546a on 3.2. It was also back ported to 3.1 but not to 2.1 and 2.2.

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #222 (f3a53b4) into develop (066c732) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #222      +/-   ##
===========================================
- Coverage    99.89%   99.89%   -0.01%     
===========================================
  Files           55       55              
  Lines         1969     1936      -33     
  Branches       158      160       +2     
===========================================
- Hits          1967     1934      -33     
  Misses           1        1              
  Partials         1        1              
Impacted Files Coverage Δ
comment/context.py 100.00% <ø> (ø)
comment/conf/defaults.py 100.00% <100.00%> (ø)
comment/templatetags/comment_tags.py 100.00% <100.00%> (ø)
comment/mixins.py 100.00% <0.00%> (ø)
comment/validators.py 100.00% <0.00%> (ø)
comment/models/flags.py 100.00% <0.00%> (ø)
comment/views/comments.py 100.00% <0.00%> (ø)
comment/api/serializers.py 100.00% <0.00%> (ø)
comment/models/comments.py 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 066c732...f3a53b4. Read the comment docs.

@abhiabhi94
Copy link
Collaborator Author

Hey @Radi85, how are you?

This has been stagnant for a long time. I just updated this branch with the main branch. In case, you have some time, it would be great to have your review on this.

@abhiabhi94
Copy link
Collaborator Author

#234 fixes the failures occurring here.

Copy link
Owner

@Radi85 Radi85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @abhiabhi94, Thanks a lot for your good work!

@Radi85 Radi85 merged commit 0254bc3 into Radi85:develop Oct 20, 2021
@abhiabhi94
Copy link
Collaborator Author

Thanks @Radi85, for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for rendering comment in markdown format
3 participants