Skip to content

Commit

Permalink
fix test comments
Browse files Browse the repository at this point in the history
  • Loading branch information
bhazelton committed Oct 10, 2024
1 parent 4714921 commit 5bcdb36
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tests/uvbeam/test_mwa_beam.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,15 @@ def test_mwa_orientation(mwa_beam_1ppd):
< power_beam.data_array[0, east_ind, 0, za_val, north_az]
)

# check that the e/w dipole is more sensitive n/s
# check that the n/s dipole is more sensitive e/w
assert (
power_beam.data_array[0, north_ind, 0, za_val, north_az]
< power_beam.data_array[0, north_ind, 0, za_val, east_az]
)

# check that for a single dipole (all others turned off) there is higher
# azimuth-aligned response near the horizon than zenith angle-aligned response
# for both feed orientations
# this is true with all dipoles on too, but the difference is bigger for a
# single dipole
delays = np.full((2, 16), 32, dtype=int)
Expand Down

1 comment on commit 5bcdb36

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 5bcdb36 Previous: 72dd3bc Ratio
tests/utils/test_bls.py::test_bls_to_ant[min=0-len=10] 5190.347527646154 iter/sec (stddev: 0.0003100549260790323) 38554.18821393712 iter/sec (stddev: 0.000013091947805193517) 7.43
tests/utils/test_bls.py::test_bls_to_ant[min=0-len=100] 11895.535670135549 iter/sec (stddev: 0.00045745180512164323) 42895.526396255875 iter/sec (stddev: 0.0000052925350897606155) 3.61
tests/utils/test_bls.py::test_bls_to_ant[min=0-len=10000] 2124.113248292355 iter/sec (stddev: 0.000890074785699803) 17153.133943111716 iter/sec (stddev: 0.000014328094102494816) 8.08
tests/utils/test_bls.py::test_bls_to_ant[min=65536-len=1] 17163.75198061446 iter/sec (stddev: 0.000064222519977668) 44005.55885505945 iter/sec (stddev: 0.000006947401622823317) 2.56
tests/utils/test_bls.py::test_bls_to_ant[min=65536-len=100] 17066.00550314419 iter/sec (stddev: 0.000028461535772301718) 41745.83447873154 iter/sec (stddev: 0.00001520973371302237) 2.45
tests/utils/test_bls.py::test_bls_to_ant[min=65536-len=1000] 13549.618032757668 iter/sec (stddev: 0.000046483140171053335) 33672.05686613388 iter/sec (stddev: 0.000012705208926630871) 2.49
tests/utils/test_bls.py::test_bls_to_ant[min=65536-len=10000] 5877.361847236135 iter/sec (stddev: 0.00017150828902007332) 16651.36143925881 iter/sec (stddev: 0.000028714782332499303) 2.83
tests/utils/test_bls.py::test_bls_to_ant[min=65536-len=100000] 1010.3741832711354 iter/sec (stddev: 0.0006772455629739942) 2697.029604108284 iter/sec (stddev: 0.00006945868233318298) 2.67
tests/utils/test_bls.py::test_bls_to_ant[min=4259840-len=1] 18216.10909562705 iter/sec (stddev: 0.00003534890832386316) 45253.21348892038 iter/sec (stddev: 0.000006309466103868728) 2.48
tests/utils/test_bls.py::test_bls_to_ant[min=4259840-len=10] 15424.417162076124 iter/sec (stddev: 0.0000942744094380688) 42057.530643802216 iter/sec (stddev: 0.000008611893556022929) 2.73
tests/utils/test_bls.py::test_bls_to_ant[min=4259840-len=100] 18583.4220038375 iter/sec (stddev: 0.00006725474639813257) 42670.934804243894 iter/sec (stddev: 0.000009504441735601591) 2.30
tests/utils/test_bls.py::test_bls_to_ant[min=4259840-len=1000] 13990.103524429627 iter/sec (stddev: 0.000046911021458966235) 35820.826656128345 iter/sec (stddev: 0.000008388776850375593) 2.56
tests/utils/test_bls.py::test_bls_to_ant[min=4259840-len=10000] 7847.827363823605 iter/sec (stddev: 0.00010867857437986338) 17546.28040765295 iter/sec (stddev: 0.000009184979574146035) 2.24
tests/utils/test_bls.py::test_bls_to_ant[min=4259840-len=100000] 1045.9129518642192 iter/sec (stddev: 0.0003174742436989842) 2842.225436345786 iter/sec (stddev: 0.00005047587926328867) 2.72
tests/utils/test_bls.py::test_ants_to_bls[min=0-len=100] 6384.766948058554 iter/sec (stddev: 0.00008424501609660875) 15272.915423788412 iter/sec (stddev: 0.00003475541385946478) 2.39
tests/utils/test_bls.py::test_ants_to_bls[min=0-len=1000] 4767.49260641726 iter/sec (stddev: 0.00009274763146824957) 9739.272703175555 iter/sec (stddev: 0.000040576578862764796) 2.04
tests/utils/test_bls.py::test_ants_to_bls[min=0-len=10000] 1217.0801352202018 iter/sec (stddev: 0.00021593618817520395) 2652.0118879050765 iter/sec (stddev: 0.00010494986632919221) 2.18
tests/utils/test_bls.py::test_ants_to_bls[min=0-len=1000000] 12.582935068756292 iter/sec (stddev: 0.01926317382873738) 25.39529318728484 iter/sec (stddev: 0.0051326475372339125) 2.02
tests/utils/test_bls.py::test_ants_to_bls[min=65536-len=1] 7672.73735855275 iter/sec (stddev: 0.00024240577969437922) 19018.809758528256 iter/sec (stddev: 0.000020634598156091437) 2.48
tests/utils/test_bls.py::test_ants_to_bls[min=65536-len=10] 5797.300620131069 iter/sec (stddev: 0.0004541126139232854) 16287.12256701289 iter/sec (stddev: 0.00005093460097387683) 2.81
tests/utils/test_bls.py::test_ants_to_bls[min=65536-len=100] 3498.02348649108 iter/sec (stddev: 0.0022999541526976084) 16502.48961933711 iter/sec (stddev: 0.000017937603983490586) 4.72
tests/utils/test_bls.py::test_ants_to_bls[min=65536-len=1000] 3752.017027036014 iter/sec (stddev: 0.002354372091047087) 10081.853191575563 iter/sec (stddev: 0.00010024060490679263) 2.69
tests/utils/test_bls.py::test_ants_to_bls[min=65536-len=10000] 1176.0164194673914 iter/sec (stddev: 0.0036249660835438427) 2626.1443811390286 iter/sec (stddev: 0.00004557742609505649) 2.23
tests/utils/test_bls.py::test_ants_to_bls[min=65536-len=1000000] 10.634965055313417 iter/sec (stddev: 0.055601443953970486) 22.342898800491287 iter/sec (stddev: 0.004313131039787093) 2.10

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.