Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small mwax metafits updates #1299

Merged
merged 2 commits into from
Jun 2, 2023
Merged

small mwax metafits updates #1299

merged 2 commits into from
Jun 2, 2023

Conversation

PyxieLouStar
Copy link
Contributor

@PyxieLouStar PyxieLouStar commented Jun 1, 2023

Update how instrument and Nants_telescope are pulled from the metafits file.

Description

Instead of using the TELESCOP field in the metafits file to set instrument, use the INSTRUME field instead. Instead of using the INSTRUME field to determine Nants_telescope, set it as the number of antennas present in the metafits antenna table. The MWAX test metafits file has been updated with the appropriate INSTRUME field.

Motivation and Context

Closes #1300

The definition of the INSTRUME field has been updated with the implementation of the MWAX correlator. For the Legacy correlator, this field indicated the number of antennas present in the array. With MWAX, this assumption is incorrect and so a different method for computing Nants_telescope is required.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

Bug fix checklist:

  • My fix includes a new test that breaks as a result of the bug (if possible).
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

@PyxieLouStar PyxieLouStar self-assigned this Jun 1, 2023
@PyxieLouStar PyxieLouStar force-pushed the small_mwax_metadata_update branch from 7644277 to 6431d37 Compare June 2, 2023 16:55
@PyxieLouStar PyxieLouStar requested a review from bhazelton June 2, 2023 16:55
bhazelton
bhazelton previously approved these changes Jun 2, 2023
Copy link
Member

@bhazelton bhazelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #1299 (cb6c400) into main (9481753) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1299   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          36       36           
  Lines       20062    20062           
=======================================
  Hits        20046    20046           
  Misses         16       16           
Impacted Files Coverage Δ
pyuvdata/uvdata/mwa_corr_fits.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9481753...cb6c400. Read the comment docs.

Copy link
Member

@bhazelton bhazelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bhazelton bhazelton merged commit 1a84890 into main Jun 2, 2023
@bhazelton bhazelton deleted the small_mwax_metadata_update branch June 2, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MWAX metafits files cause an error
2 participants