Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error message if az_za_grid set but no az_array or za_array #1302

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

bhazelton
Copy link
Member

Description

Give users a better error message if they set az_za_grid=True in UVBeam.interp but do not provide both the az_array and za_array.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

New feature checklist:

  • I have added or updated the docstrings associated with my feature using the numpy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate).
  • I have added tests to cover my new feature.
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

@bhazelton bhazelton added beams docs documentation labels Jun 5, 2023
@bhazelton bhazelton requested a review from steven-murray June 5, 2023 22:14
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #1302 (ef4d6c0) into main (1a84890) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1302   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          36       36           
  Lines       20062    20064    +2     
=======================================
+ Hits        20046    20048    +2     
  Misses         16       16           
Impacted Files Coverage Δ
pyuvdata/uvbeam/uvbeam.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a84890...ef4d6c0. Read the comment docs.

@steven-murray steven-murray merged commit 986976c into main Jun 8, 2023
@steven-murray steven-murray deleted the uvbeam_interp_better_error branch June 8, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beams docs documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants