Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some ERFA calls #1331

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Fix some ERFA calls #1331

merged 3 commits into from
Aug 25, 2023

Conversation

bhazelton
Copy link
Member

@bhazelton bhazelton commented Aug 24, 2023

Description

Fixes some ERFA calls that were missed in #1314 for calculating apparent coordinates and add one small improvement to the ERFA LST calculation.

Motivation and Context

Fixes #1315
Fixes #1318

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

Bug fix checklist:

  • My fix includes a new test that breaks as a result of the bug (if possible).
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #1331 (c998954) into main (4ff6808) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1331   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          36       36           
  Lines       19942    19943    +1     
=======================================
+ Hits        19926    19927    +1     
  Misses         16       16           
Files Changed Coverage Δ
pyuvdata/utils.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ff6808...c998954. Read the comment docs.

Copy link
Contributor

@kartographer kartographer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bhazelton -- all looks good to me!

@bhazelton bhazelton merged commit 6c456ee into main Aug 25, 2023
@bhazelton bhazelton deleted the erfa_lst_fix branch August 25, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants