-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a UVBeam.new()
method similar to the ones on UVData and UVCal
#1378
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1378 +/- ##
========================================
Coverage 99.92% 99.92%
========================================
Files 36 37 +1
Lines 20252 20423 +171
========================================
+ Hits 20236 20407 +171
Misses 16 16
Continue to review full report in Codecov by Sentry.
|
4861545
to
a453036
Compare
Deprecate the unused `spw_array` and `Nspws` attributes on UVBeam. Deprecate the `UVBeam.freq_interp_kind` attribute in favor of a parameter on the interp method. Deprecate upper case strings in UVBeam.feed_array
ba2d9f8
to
5d35fff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bhazelton, this looks great (love all the typing...). Only a few easy comments to fix up.
I'm also working on fixing up the pyuvsim errors, they're related to the change in handling of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks -- yeah I think you made the right decision on the default names.
Description
I realized that this was needed for a planned
AnalyticBeam.to_uvbeam()
method and decided it was cleaner to make a separate PR for this. I followed the similar UVCal and UVData methods.In the process I also realized there were a few needed deprecations, so I:
spw_array
andNspws
attributes on UVBeam. (Note these are currently optional, but there is no correspondingspw_ind_array
attribute, so they aren't useful. I cannot see a purpose for SPW support on UVBeam objects and neither can several other people I checked in with.)UVBeam.freq_interp_kind
attribute in favor of a parameter on the interp method (similar to what was done for theinterpolation_function
attribute in Improve beam interp docs #1246)Motivation and Context
Types of changes
Checklist:
New feature checklist:
Breaking change checklist: