Fix so that write_uvfits doesn't change the object, add loopback testing #1393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a minor problem with the recent addition of the
use_miriad_convention
keyword to uvfits.Namely, it could actually change the antenna numbers on the object, which wasn't desirable (and it didn't update the baseline_array to match).
This also adds some loopback testing to ensure that pyuvdata can properly read in a file written out with
use_miriad_convention=True
.Motivation and Context
Types of changes
Checklist:
Bug fix checklist: