Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix so that write_uvfits doesn't change the object, add loopback testing #1393

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

bhazelton
Copy link
Member

Description

This fixes a minor problem with the recent addition of the use_miriad_convention keyword to uvfits.

Namely, it could actually change the antenna numbers on the object, which wasn't desirable (and it didn't update the baseline_array to match).

This also adds some loopback testing to ensure that pyuvdata can properly read in a file written out with use_miriad_convention=True.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

Bug fix checklist:

  • My fix includes a new test that breaks as a result of the bug (if possible).
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4d66558) 99.92% compared to head (e1ab6f0) 99.92%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1393   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          37       37           
  Lines       20445    20446    +1     
=======================================
+ Hits        20429    20430    +1     
  Misses         16       16           
Files Coverage Δ
pyuvdata/uvdata/uvfits.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d66558...e1ab6f0. Read the comment docs.

Copy link
Contributor

@kartographer kartographer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @bhazelton!

@kartographer kartographer merged commit b86712a into main Feb 8, 2024
47 of 53 checks passed
@kartographer kartographer deleted the fix_write_uvfits branch February 8, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants