Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore warnings in hera_cal and hera_qm test runs #1402

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

bhazelton
Copy link
Member

@bhazelton bhazelton commented Feb 13, 2024

Description

To make it easier to see the actual errors. This only ignores warnings that are not coming from pyuvdata.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

Build or continuous integration change checklist:

  • If required or optional dependencies have changed (including version numbers), I have updated the readme to reflect this.
  • If this is a new CI setup, I have added the associated badge to the readme and to references/make_index.py (if appropriate).

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b5333f) 99.92% compared to head (9246a97) 99.92%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1402   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          37       37           
  Lines       20766    20766           
=======================================
  Hits        20750    20750           
  Misses         16       16           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b5333f...9246a97. Read the comment docs.

Copy link
Contributor

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, maybe we should be more selective in what warnings are ignored. The warnings docs say that the warnings format is:

action:message:category:module:line

We probably want to only capture DeprecationWarning from pyuvdata? So:

-W ignore,default::DeprecationWarning:pyuvdata

@bhazelton
Copy link
Member Author

bhazelton commented Feb 14, 2024

Thanks! I backed it off some to only ignore non-pyuvdata warnings. I didn't limit to only pyuvdata Deprecation Warnings because we've broken hera_qm before with new pyuvdata user warnings because of the warning testing in hera_qm.

I tested this on my machine by adding a new warning and it worked.

Copy link
Contributor

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@steven-murray steven-murray merged commit b448881 into main Feb 21, 2024
53 checks passed
@steven-murray steven-murray deleted the ignore_warnings_hera branch February 21, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants