Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expected behavior is for
mwa_corr_fits
to have the default settingcorrect_cable_len=True
but instead the default is `correct_cable_len=None". This pull request fixes the default setting.Description
A test is also added to test that all three corrections--cable length, digital gains, and polyphase filter bank bandpass--are applied by default by
read_mwa_corr_fits
.Motivation and Context
In transitioning the default behavior of
correct_cable_len=False
to a new default ofcorrect_cable_len=True
, there was an intermediate stage in whichcorrect_cable_len
was set asNone
with handling later in the code. Inadvertently, during the transition process the default incorrectly becamecorrect_cable_len=None
.closes #1418
Types of changes
Checklist:
Bug fix checklist: