Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix correct_cable_len default #1419

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Fix correct_cable_len default #1419

merged 3 commits into from
Mar 27, 2024

Conversation

PyxieLouStar
Copy link
Contributor

@PyxieLouStar PyxieLouStar commented Mar 23, 2024

The expected behavior is for mwa_corr_fits to have the default setting correct_cable_len=True but instead the default is `correct_cable_len=None". This pull request fixes the default setting.

Description

A test is also added to test that all three corrections--cable length, digital gains, and polyphase filter bank bandpass--are applied by default by read_mwa_corr_fits.

Motivation and Context

In transitioning the default behavior of correct_cable_len=False to a new default of correct_cable_len=True, there was an intermediate stage in which correct_cable_len was set as None with handling later in the code. Inadvertently, during the transition process the default incorrectly became correct_cable_len=None.

closes #1418

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

Bug fix checklist:

  • My fix includes a new test that breaks as a result of the bug (if possible).
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

@PyxieLouStar PyxieLouStar changed the title Fix correct_corr_len default Fix correct_cable_len default Mar 23, 2024
bhazelton
bhazelton previously approved these changes Mar 25, 2024
@PyxieLouStar PyxieLouStar force-pushed the fix_cable_correction_default branch from 6f0ed15 to 36a9c45 Compare March 27, 2024 14:12
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (f82e089) to head (a2fd2dd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1419   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          37       37           
  Lines       20871    20871           
=======================================
  Hits        20855    20855           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PyxieLouStar PyxieLouStar requested a review from bhazelton March 27, 2024 15:11
Copy link
Member

@bhazelton bhazelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@bhazelton bhazelton merged commit f9d0df7 into main Mar 27, 2024
44 checks passed
@bhazelton bhazelton deleted the fix_cable_correction_default branch March 27, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read_mwa_corr_fits cable length correction is defaulting to None
2 participants