Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always cast antpairs to int #1448

Merged
merged 2 commits into from
Jun 21, 2024
Merged

fix: always cast antpairs to int #1448

merged 2 commits into from
Jun 21, 2024

Conversation

steven-murray
Copy link
Contributor

Description

Fixes #1445 by always casting the antpairs array to int.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

Bug fix checklist:

  • My fix includes a new test that breaks as a result of the bug (if possible).
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

@steven-murray steven-murray requested a review from bhazelton June 19, 2024 17:52
@steven-murray steven-murray self-assigned this Jun 19, 2024
bhazelton
bhazelton previously approved these changes Jun 20, 2024
Copy link
Member

@bhazelton bhazelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the quick fix!

@steven-murray
Copy link
Contributor Author

@bhazelton I should wait for the numpy thing to be solved before merging, yes?

@bhazelton
Copy link
Member

yes. I think you'll need to rebase after that is merged.

@bhazelton
Copy link
Member

Ok #1447 has been merged, so if you rebase this one I think the tests will pass.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (70a4127) to head (396b249).
Report is 305 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1448   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          36       36           
  Lines       20839    20839           
=======================================
  Hits        20823    20823           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@steven-murray steven-murray merged commit ad0f9d6 into main Jun 21, 2024
44 checks passed
@steven-murray steven-murray deleted the fix-1445 branch June 21, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New UVdata creates float antenna number arrays which are not allowed by pyuvdata check
2 participants