Skip to content

Commit

Permalink
Upgrade rubocop dependency to 1.24.1
Browse files Browse the repository at this point in the history
Co-authored-by: Alex Stone <astone@radiusnetworks.com>
Co-authored-by: Eric Ouellette <eric.s.ouellette@gmail.com>
Co-authored-by: James Nebeker <jnebeker@radiusnetworks.com>
Co-authored-by: JC Avena <jcavena@gmail.com>
  • Loading branch information
5 people committed Jan 7, 2022
1 parent 3755aa0 commit f944ca3
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
15 changes: 15 additions & 0 deletions common_rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,21 @@ Metrics/MethodLength:
Naming/BinaryOperatorParameterName:
Enabled: false

# We don't need this configured just yet, because we dont have any applications on
# Ruby 3.1, but pre-emptively, we want to configure this to prefer the explicit style.
#
# bad
# def foo(&)
# bar(&)
# end

# good
# def foo(&block)
# bar(&block)
# end
Naming/BlockForwarding:
EnforcedStyle: explicit

# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms.
# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
Naming/FileName:
Expand Down
2 changes: 1 addition & 1 deletion radius-spec.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Gem::Specification.new do |spec|
spec.required_ruby_version = ">= 2.5" # rubocop:disable Gemspec/RequiredRubyVersion

spec.add_runtime_dependency "rspec", "~> 3.7"
spec.add_runtime_dependency "rubocop", "~> 1.23.0"
spec.add_runtime_dependency "rubocop", "~> 1.24.0"
spec.add_runtime_dependency "rubocop-rails", "~> 2.12.0"

spec.add_development_dependency "bundler", ">= 2.2.10"
Expand Down

0 comments on commit f944ca3

Please sign in to comment.