Fix File Name Toggle not updating ColumnProperties properly #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1029
Bug :
The File name toggle was being updated as isHidden not !isHidden, while the UI element is being updated as !isHidden.
This particular part of the codebase is confusing due to the File name following a different convention to track if it is hidden or not than all other properties. All other properties use the config propriety show_metadata_NAME to determine the toggle state which is true when the toggle should be on, however, the File property uses isHidden directly causing the toggle to be on when the isHidden bool is False.
Given enough dev time I think it would be a good idea to refactor the Name metadata to be tracked and handled the same way that other metadata is handled.
Fix
isHidden Value is set to !isHidden both during toggle render and in the present variable
Temp fix for users until new build is deployed
You can double toggle to get the desired result of a single toggle.
My apologies for not going through the official pipeline to requesting the ability to work on an issue. I ended up reading the contribution guidelines after I had already forked and found the solution.