move from using project_name to project_id #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David O'Dell <davidodell@gmail.com>
RafikFarhad
approved these changes
Jul 31, 2020
|
Hello @dodizzle thank you very much for your PR. |
|
Hello @dodizzle, your changes is now usable via version |
|
No problem. BTW next week I will open a PR add the option to generate a tag from the git-sha or the date stamp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using project_name is a little bit misleading as it actually needs to be the project_id which some times is not always the same as the project_name.
I tested this using project_id instead of project_name and it works.
Signed-off-by: David O'Dell davidodell@gmail.com