Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified serial port buffer size for windows to 1 #433

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Modified serial port buffer size for windows to 1 #433

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e07d103
Modified serial port buffer size for windows to 1
Fundevoge Aug 28, 2023
ee63866
Added comment expaining the fix for windows
Fundevoge Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ravedude/src/console.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,13 @@ pub fn open(port: &std::path::Path, baudrate: u32) -> anyhow::Result<()> {

// Spawn a thread for the receiving end because stdio is not portably non-blocking...
std::thread::spawn(move || loop {
#[cfg(not(target_os = "windows"))]
let mut buf = [0u8; 4098];

// Use buffer size 1 for windows because it blocks on rx.read until the buffer is full
#[cfg(target_os = "windows")]
Fundevoge marked this conversation as resolved.
Show resolved Hide resolved
let mut buf = [0u8; 1];

match rx.read(&mut buf) {
Ok(count) => {
stdout.write(&buf[..count]).unwrap();
Expand Down