generic: port: Fix toggle() for dynamic pins #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During commit 063f845 ("generic: simplify port macro via `paste!`"), an accidental change was introduced where out_toggle() for dynamic pins wrote to the `PORT` register instead of the `PIN` register. This meant that toggle() for dynamic pins no longer worked. Fix this regression by making out_toggle() write to `PIN` again. Fixes: 063f845 ("generic: simplify port macro via `paste!`")
|
@Rahix While debugging a toggle problem on an AtMega16 (see #642) I came across this PR. I did not understand how the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During commit 063f845 ("generic: simplify port macro via
paste!"), an accidental change was introduced where out_toggle() for dynamic pins wrote to thePORTregister instead of thePINregister. This meant that toggle() for dynamic pins no longer worked.Fix this regression by making out_toggle() write to
PINagain.Fixes #499.